https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32773
Marcel de Rooy <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|[email protected] |[email protected] |y.org | Status|Signed Off |Failed QA --- Comment #58 from Marcel de Rooy <[email protected]> --- QA comment: Looks much. But should not be that hard. Good job. FAIL installer/data/mysql/atomicupdate/bug_32773.pl FAIL file permissions File must have the exec flag prove t/db_dependent/Koha/Biblio.t t/db_dependent/Koha/Biblio.t .. ok All tests successful. Files=1, Tests=40, 53 wallclock secs ( 0.07 usr 0.01 sys + 42.71 cusr 8.57 csys = 51.36 CPU) Result: PASS No blocker but small inconsistency: + `is_fast_add` tinyint(1) NOT NULL DEFAULT 0 COMMENT 'the ability to be used as a Fast Add framework', + ALTER TABLE biblio_framework + ADD COLUMN is_fast_add TINYINT(1) NOT NULL DEFAULT 0 + AFTER frameworktext; You did not add the comment in the dbrev. No blocker too but a potential case problem. Look at git grep 'Fast Add' and git grep 'Fast add'. I feel that the latter is the correct one ? + <label for="is_fast_add">Use as a Fast Add framework: </label> + <span class="badge rounded-pill bg-secondary float-end">Fast Add</span> + [% !framework ? 'Default' : framework.frameworktext | html %] Not sure about this? Add parentheses to avoid confusion. + $frameworkcode eq 'FA' || $is_fast_add +if ( $frameworkcode eq 'FA' || $is_fast_add ) { + more occurrences Shouldnt this be just testing is_fast_add now ? + [% IF CAN_user_editcatalogue_edit_items or ( frameworkcode == 'FA' || is_fast_add and CAN_user_editcatalogue_fast_cataloging ) %] Think that this needs more parentheses to get the condition evaluation right. Here too in includes/cat-toolbar.inc ( frameworkcode == 'FA' || is_fast_add and CAN_user_editcatalogue_fast_cataloging ) %] More occurrences +my $frameworkcode = &GetFrameworkCode($biblionumber); +my $is_fast_add = + defined $frameworkcode && $frameworkcode ne '' + ? Koha::BiblioFrameworks->find($frameworkcode)->is_fast_add + : 0; Why call GetFrameworkCode if you have a $biblio object? Same here +my $fw = GetFrameworkCode($biblionumber); +my $is_fast_add = Koha::BiblioFrameworks->find($fw)->is_fast_add; +my $all_items = $biblio->items->search_ordered; -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
