https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32773
--- Comment #59 from Brendan Lawlor <[email protected]> --- Thanks for the code review, Marcel! I'm working on addressing these concerns and will post updated patches soon. For Why call GetFrameworkCode if you have a $biblio object? It was already written like this in some other places like moredetail.pl so I just followed this pattern: my $fw = GetFrameworkCode($biblionumber); maybe in that case it is because $biblio could potentially be undefined? If you do have a biblio object, would it be better written as: my $frameworkcode = $biblio->frameworkcode; -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
