http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
--- Comment #74 from Galen Charlton <[email protected]> --- (In reply to comment #71) > (In reply to comment #70) > > I think it would be a reasonable goal to get to the point where, once the > > cycle for 3.16 starts, DBIC is required for any new code that interacts with > > the database. That can't be a requirement for 3.14, of course, but we can > > certainly encourage it. > +1, even if the big deal here will be to mix DBIC & C4/ code: I want to add > a feature that could use C4/Acquisition.pm::whatever. Should I write a > Koha/BusinessLogic::whatever_for_DBIC anyway ? I don't see an clear answer > to this question. If I answer yes, then it mean there are 2 "whatever" > functions, that will be a pain to maintain. My preference is that that every effort should be made when introducing a DBIC-based method to remove the C4 function(s) that it supersedes; having both a Koha::* method and a C4::* method for the same thing only invites trouble in the form of divergent business logic. Developing new features incrementally can help with that. Of course, I can imagine circumstances where following the recommendation above would require refactoring an unwieldy amount of code. In cases like that, I will *consider* patches that result in Koha/C4 duplication provided that the C4 function is clearly marked as deprecated. If such a patch gets pushed, I'd say that no new code that uses the C4 function would subsequently be allowed. Since all of this refactoring we're facing means that we're essentially building a whole new API, I *strongly* encourage folks to discuss their proposals for refactoring particular methods on koha-devel first. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
