https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40032
Bug ID: 40032
Summary: Make SIP2 log missing active currency
Change sponsored?: ---
Product: Koha
Version: Main
Hardware: All
OS: All
Status: NEW
Severity: minor
Priority: P5 - low
Component: SIP2
Assignee: [email protected]
Reporter: [email protected]
QA Contact: [email protected]
We just had a situation where "Patron Status Requests" were failing, because no
currency was set to active. There was a warning about this in "About Koha >
System information", but it would be nice if there was a warning in the SIP2
log too.
To reproduce in KTD:
Make sure not currency is active, then:
$ telnet localhost 6001
Trying 127.0.0.1...
Connected to localhost.
Escape character is '^]'.
9300CNterm1|COterm1|CPCPL
941
2300120250530 090947AOCPL|AAterm1|AC|ADterm1
Connection closed by foreign host.
In /var/log/koha/kohadev/sip-output.log:
[2025/05/30 08:34:28] [2336] [INFO] [email protected]: INPUT MSG: '2300120250530
090947AOCPL|AAterm1|AC***|ADterm1' C4::SIP::Sip::siplog
/kohadevbox/koha/C4/SIP/Sip.pm (319)
[2025/05/30 08:34:28] [2336] [DEBUG] [email protected]:
Sip::MsgType::new('C4::SIP::Sip::MsgType', '2300120250...', '23'): seq.no '0',
protocol 2 C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (319)
[2025/05/30 08:34:28] [2336] [DEBUG] [email protected]:
Sip::MsgType::_initialize('Patron Status Request', '00120250530
090947AOCPL|AAterm1|AC***|ADterm1', 'A3A18', '21', ...) C4::SIP::Sip::siplog
/kohadevbox/koha/C4/SIP/Sip.pm (319)
[2025/05/30 08:34:28] [2336] [DEBUG] [email protected]: Debarred = undef :
C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (319)
[2025/05/30 08:34:28] [2336] [INFO] [email protected]: raw_transport: shutting
down C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (319)
Suggested solution:
In C4::SIP::ILS::Patron::new() we do this:
# Get currency 3 chars max
my $currency = substr Koha::Acquisition::Currencies->get_active->currency,
0, 3;
We could add a check for defined $currency and a log message if it is not
defined.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
