https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

--- Comment #490 from David Cook <[email protected]> ---
(In reply to David Cook from comment #488)
> (In reply to Pedro Amorim from comment #486)
> > - Staff: Hold group modal (when clicking the "(part of a hold group link)")
> > contains out of date UI elements styling
> 
> How do you mean? (I'll take a look at other modals for inspiration while I
> wait to hear back.)

I'm comparing "koha-tmpl/intranet-tmpl/prog/en/includes/hold-group-modal.inc"
to the modals in "koha-tmpl/intranet-tmpl/prog/en/includes/modals". 

Unfortunately, not sure what you mean here.

> > - Staff: Hold group modal 'x' and 'close' button don't work.
> 
> Yep, known issue. I'll look at fixing that. 

Fixed in next patch upload.

> > - Staff: After the above, when visiting the holds queue page, I get a 500
> > error with the following entry on the logs:
> > # Not an ARRAY reference at /kohadevbox/koha/circ/view_holdsqueue.pl line 
> > 58.
> 
> Yep known issue. (It works locally so I'll have to investigate why it works
> locally. )

Locally, we've just removed support for "(part of a hold group link)" in
http://localhost:8081/cgi-bin/koha/circ/view_holdsqueue.pl because the table
there is from the tmp_holdsqueue table and hold_group_id is not a column in
that table. 

I'm going to do the same thing in the next patch upload, but this might need a
better solution. 

In practice, the lack of support here hasn't been an issue for the library
using this feature. 

> > - OPAC: Using koha:koha user in ktd, when creating a hold group from the
> > OPAC, following the "Gairm" and "Clean code" example, I get the following
> > error message:
> > # One or more holds were not placed due to following errors: You have
> > exceeded the number of concurrent holds for this record
> > But if I place both holds without ticking the 'treat as hold group'
> > checkbox, both holds are correctly placed.
> > I was unable to follow the rest of the OPAC test plan.

Fixed in next patch upload.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to