https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516
--- Comment #493 from Pedro Amorim <[email protected]> --- (In reply to David Cook from comment #488) > (In reply to Pedro Amorim from comment #486) > > - Staff: Hold group modal (when clicking the "(part of a hold group link)") > > contains out of date UI elements styling > > How do you mean? (I'll take a look at other modals for inspiration while I > wait to hear back.) Looks good and works as expected now after the additional patches. > > - Staff: Created a hold group searching 'music' and picking 1st and 3rd > > records. After checking in one item of a hold group and confirming, the item > > became in transit, the other hold was not deleted (I would expect it to be > > deleted as per the test plan) > > I'm not able to reproduce this. I thought that I did reproduce it... but it > was just because I forgot to checkbox the "hold group" box. Fresh k-t-d, all patches applied, reset_all (DisplayAddHoldGroups already enabled): 1) Search for 'music': http://localhost:8081/cgi-bin/koha/catalogue/search.pl?q=music 2) Select the checkbox on the 1st record (Nordic roots) and 3rd record (Clothes, clothes...) 3) Click the 'Place hold' button 4) Search for 'koha (42)' user. Pick that. 5) Check the 'treat as hold group' checkbox 6) Select the pickup locations 'Fairfield' for Nordic root, 'Fairview' for Clothes, clothes... Click 'Place holds'. 7) Visit the user page: http://localhost:8081/cgi-bin/koha/members/moremember.pl?borrowernumber=51 8) Notice the holds tab marks '1' hold (considering the hold group as one hold) but lists both holds, with each having the 'part of a hold group' link. 9) Check-in an item of 'Nordic roots': 39999000003154 10) Click 'Confirm hold and transfer'. 11) Repeat 7) Notice both holds are still present. I would expect the 'Clothes, clothes...' hold to have been deleted now that the hold group has been satisfied. > > - OPAC: Using koha:koha user in ktd, when creating a hold group from the > > OPAC, following the "Gairm" and "Clean code" example, I get the following > > error message: > > # One or more holds were not placed due to following errors: You have > > exceeded the number of concurrent holds for this record > > But if I place both holds without ticking the 'treat as hold group' > > checkbox, both holds are correctly placed. > > I was unable to follow the rest of the OPAC test plan. > > Ok I've reproduced this. It's one of those examples of something I've fixed > locally in production but hadn't fixed in the Bugzilla patches... I'll get > that fixed. Simple fix. Can't reproduce anymore. Works as described on the test plan. > > - Staff: As above, when doing the same exercise on Staff UI, only 'Clean > > code' hold goes through, 'Gairm' hold is never created. No error message > > shown. > > This is very weird. I just re-tried the test plan again and it worked for > both the OPAC and Staff interface. Are you sure that you applied the patch, > updated the schema, and restarted your Starman? Can't reproduce anymore. Works as described on the test plan. Note that the test plan works if the checked in item is to be picked up at the same library as the patron. Checked in ttem becomes 'waiting'. The other hold in the hold group is deleted. As per my instructions above, for both Staff and OPAC, if the item that satisfied the hold group becomes "In transit", the other hold in the hold group is not deleted. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
