https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40300
Marcel de Rooy <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] Status|Signed Off |Failed QA --- Comment #12 from Marcel de Rooy <[email protected]> --- Apart from discussing spaces or tabs, punctuation is a great alternative, haha :) I did a git grep on xsl:text with some punct chars (discarding UNIMARC): git grep "<xsl:text> [,;.:]" | grep -v UNIMARC koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slimUtils.xsl: <xsl:text> ; </xsl:text><xsl:value-of select="marc:subfield[@code='v']" /> koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slimUtils.xsl: <xsl:text> ; </xsl:text><xsl:value-of select="marc:subfield[@code='v']" /> koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slimUtils.xsl: <xsl:text> ; </xsl:text> koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slimUtils.xsl: <xsl:text> ; </xsl:text><xsl:value-of select="marc:subfield[@code='v']" /> koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slimUtils.xsl: <xsl:text> ; </xsl:text><xsl:value-of select="marc:subfield[@code='v']" /> koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slimUtils.xsl: <xsl:text> ; </xsl:text><xsl:value-of select="marc:subfield[@code='v']" /> koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slimUtils.xsl: <xsl:text> ; </xsl:text> koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slimUtils.xsl: <xsl:text> ; </xsl:text><xsl:value-of select="marc:subfield[@code='v']" /> Looking at those results, it is always the series $v that is preceded by a semicolon. Normally, the xslt's do not add such punctuation, but just insert spaces. So I would recommend here not to call ChopPunctuation but remove those preceding semicolons in the $v display. That seems to be a more consistent approach. Please feel free to provide counter documentation. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
