https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40300
--- Comment #17 from Alexander Wagner <[email protected]> --- (In reply to Bernard from comment #16) > As I am not a cataloguer, my understanding of some of the detail here is no > doubt hazy. However, I think in a nutshell we are saying we don't want to > break well catalogued records but we'd like Koha to try to fix ones that are > not, or at least to some degree. I think this is the gist of it. BTW: just noticed that in #21303 Caroline stumbled upon the automatic fixing via XSLT. (I knew I already read a bug on this, that's was reason for my initial comment.) > Given that the rules may vary by field, it > seems to me that using a separate punc.pm as drafted in bugs #21313, #37196 > and #37325 is going to be the best way to achieve this and not make the xslt > unwieldy. Indeed, my first approach was by XSLT, but I was happy to learn from Cait that Mark filters exist and could be used for this, even though right now the filters applied are in a static array in the code. (Still the use case would be general enough to justify a change to the list, I think) > Not that this is a trivial piece of work of course. Agree. I split it up by fields as I think it would allow for a pragmatic approach adding fields as we stumble upon them. Probably fixing up the XSLT on the way. So Koha could improve over time without blocking everything by a huge overhaul. But maybe there is a better approach? > I would favour an approach where the each relevant field is presented to > punc.pm. If it is "correct" anyway, nothing would be changed and if it is > not, then it would be fixed up and returned. This way we do not need to > consider leader 18 at all. I do not yet get how you know if a record is "correct"? Say, I take a tag and pass it though the automatic punctuation and compare it to the punctuation presented. It could be the same or differ. But what is "correct"? If we treat "the same" as correct, we are implicitly enforcing the rules of `Punctuation.pm` to all records as all those that differ get rewritten and those that are the same already follow the very rules. I could imagine a system setting, if you want a way to disregard the leader. (Seems you have good reason to distrust it.) Something along the lines: RewritePunctuation: - Never -> do nothing - Always -> chop and add - Evaluate leader 18 -> respect the leaders value on a per record basis Looking at your initial issue one could ponder if a general rule makes sense that checks if the same char appears twice. E.g. if the punctuation char is ` ;` one could replace ` ; ;` by ` ;`. But I am not sure if there isn't a strange case, I am not aware of, where something like this could even be "correct". -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
