https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40608
--- Comment #5 from Tomás Cohen Arazi (tcohen) <[email protected]> --- (In reply to Marcel de Rooy from comment #4) > + $schema->resultset('Letter')->search( > Old syntax. We have Koha::Notice::Template ? Good catch. I didn't notice there was a Koha::Object-based class for them. > + # Verify no PASSWORD_CHANGE letter exists > + my $letter_count = $schema->resultset('Letter')->search( > + { > + code => 'PASSWORD_CHANGE', > + module => 'members' > + } > + )->count; > + is( $letter_count, 0, 'No PASSWORD_CHANGE letter template > exists' ); > Overkill? Testing DBIx here? Fair, can remove the test. > We should probably warn if they enable Notify and you have an email address > but dont have a letter for it ? > Now we silently ignore. We did silently ignore already, it is just that the password change was not stored. And it is not silently, as there's a warn already about the missing letter. I think a follow-up adding a check for this in about.pl wouldn't hurt. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
