https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40608
Marcel de Rooy <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185241|0 |1 is obsolete| | --- Comment #13 from Marcel de Rooy <[email protected]> --- Created attachment 185260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185260&action=edit Bug 40608: (follow-up) Some tests rely on existing data Playing with the about page, I noticed prior tests in the codebase fail if the letter doesn't exist. This patch fixes that. To test: 1. With a fresh KTD run: $ ktd --shell k$ prove t/db_dependent/Koha/Patron.t => SUCCESS: Tests pass! 2. Delete the existing notices: k$ koha-mysql kohadev > DELETE FROM letter WHERE code="PASSWORD_CHANGE"; \q 3. Repeat 1 => FAIL: Tests fail! Current tests print a warn (Test::NoWarning) doesn't like this 4. Apply this patch 5. Repeat 1 => SUCCESS: Tests now pass. The test creates its own notice. 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi <[email protected]> Signed-off-by: Marcel de Rooy <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
