https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40910

--- Comment #4 from Kyle M Hall (khall) <[email protected]> ---
(In reply to Kyle M Hall (khall) from comment #3)
> I would recommend running barcode decode *after* doing all your checks on
> item_id, as barcodedecode can trigger plugins that will *generate* a new
> barcode if passed an empty barcode string (
> https://github.com/bywatersolutions/koha-plugin-barcode-prefixer ) for
> example. 
> 
> By testing $item_id and returning if it's empty *before* running
> barcodedecode on it, we can ensure we don't accidentally generate a
> non-existent barcode for the message!

My entire comment is invalid as Tomas already added a return on line 88.
I think the log level is good as well, we should be able to scroll back in the
logs to see the message that triggered the error.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to