https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893
--- Comment #47 from David Cook <[email protected]> --- Finally getting around to this... Not planning to be a blocker. Just going to share some notes/observations. If there's anything that needs changing, I figure it can be done in a future follow-up bug. -- Notes: 1. Curious why etc/SIPconfig.xml and debian/templates/SIPconfig.xml have comments added rather than having their legacy sections removed? 2. I would've expected to find "Self-service circulation (SIP2)" under "Additional parameters" rather than "Patrons and circulation" in Admin, but I suppose it makes a certain conceptual sense. 3. The description in on admin-home.pl still includes "server parameters" which I think is incorrect. 4. Curious why "sip2.pl" went into its own "sip2" directory. Guessing it's because of imitating "erm". I don't think this is a good move for the long-term organisation of Koha source code, but c'est la vie I guess. 5. It looks like there is no way to define a password for a SIP2 account in the web ui, but... that's because it uses the actual borrower account, so it's no longer required to store the password in plain text. Oh that's very cool. I can imagine that would confuse some people, but still... very cool. (I also like how you can update the password for a user and you don't have to restart the SIP server. Excellent.) 6. The console is full of "Incorrect use of <label for=FORM_ELEMENT>" page errors. The browser says this could negatively affect accessibility tools. 7. There is no validation on the "Staff userid for SIP2 authentication". You can put anything you like. That one would be cool to be done by a dropdown menu which only shows users that have appropriate permissions. 8. I can't find an easy way to test institutions with the time and data I have at hand right now, so I'm going to just assume they work correctly. It would've been good to have a more comprehensive test plan with things like checkins and checkouts to prove that the change works... Actually I just realised the wiki has some things for this... Hmm... I can't seem to perform SIP checkouts... perl misc/sip_cli_emulator.pl -su koha -sp 1Test1Test -l CPL --host localhost --patron 42 -m checkout --item 39999000001310 Attempting socket connection to localhost:6001...connected! SEND: 9300CNkoha|CO1Test1Test|CPCPL| READ: 941 Trying 'checkout' SEND: 11YN20251030 05164020251030 051640AOCPL|AA42|AB39999000001310|AC1Test1Test|BIN| READ: undef Seeing the following in sip-output.log: [2025/10/30 05:17:48] [23774] [WARN] [email protected]: DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Data too long for column 'branchcode' at row 1 at /kohadevbox/koha/Koha/Object.pm line 174 Try: :Tiny::try /usr/share/perl5/Try/Tiny.pm (123) [2025/10/30 05:17:48] [23774] [ERROR] [email protected]: DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Data too long for column 'branchcode' at row 1 at /kohadevbox/koha/Koha/Object.pm line 174 C4: :SIP::Trapper::__ANON__ /kohadevbox/koha/C4/SIP/Trapper.pm (70) [2025/10/30 05:17:48] [23774] [ERROR] [email protected]: DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Data too long for column 'branchcode' at row 1 at /kohadevbox/koha/Koha/Object.pm line 174 C4: :SIP::Trapper::__ANON__ /kohadevbox/koha/C4/SIP/Trapper.pm (70) [2025/10/30 05:17:48] [23774] [INFO] [email protected]: raw_transport: shutting down C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (327) Ah that's because I'd updated the account to use "kohalibrary" in Accounts which is an invalid institution. Changed it back to CPL and now it's working. 9. Hmmm I turned off "Checkin" for the CPL institution but it still let me checkin... maybe it does require a restart. I'll re-test that... Hmm nope... still allows checkin after a restart of the SIP server. Although to be fair I don't know if any of those attributes ever worked in SIPconfig.xml either. -- Overall, it's looking pretty good I think. I think it's a good move in the right direction for sure. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
