https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893
--- Comment #49 from Pedro Amorim <[email protected]> --- (In reply to David Cook from comment #47) > Finally getting around to this... > > Not planning to be a blocker. Just going to share some notes/observations. > If there's anything that needs changing, I figure it can be done in a future > follow-up bug. Thank you for your time here David. > > Notes: > 1. Curious why etc/SIPconfig.xml and debian/templates/SIPconfig.xml have > comments added rather than having their legacy sections removed? Fair, I'm not sure exactly why I decided this way, but I agree that it should be remove, although as you say trivial and non-blocker. > 2. I would've expected to find "Self-service circulation (SIP2)" under > "Additional parameters" rather than "Patrons and circulation" in Admin, but > I suppose it makes a certain conceptual sense. Up for debate I suppose, personally don't feel strongly about this and happy to follow-up if required. > 3. The description in on admin-home.pl still includes "server parameters" > which I think is incorrect. Good spot. Patch provided: https://github.com/openfifth/koha/commit/fa5d3b678123e1f8d5d968923897861006486e2e > 4. Curious why "sip2.pl" went into its own "sip2" directory. Guessing it's > because of imitating "erm". I don't think this is a good move for the > long-term organisation of Koha source code, but c'est la vie I guess. Correct, to adhere to established pattern. > 5. It looks like there is no way to define a password for a SIP2 account in > the web ui, but... that's because it uses the actual borrower account, so > it's no longer required to store the password in plain text. Oh that's very > cool. I can imagine that would confuse some people, but still... very cool. > (I also like how you can update the password for a user and you don't have > to restart the SIP server. Excellent.) > > 6. The console is full of "Incorrect use of <label for=FORM_ELEMENT>" page > errors. The browser says this could negatively affect accessibility tools. I cannot see this. Can you please provide more information e.g. which page, what browser. > 7. There is no validation on the "Staff userid for SIP2 authentication". You > can put anything you like. That one would be cool to be done by a dropdown > menu which only shows users that have appropriate permissions. This is the follow-up suggestion Martin is referring to in his comment. We discussed and agreed that a 'patron search' relationship type of input is required to be added to the framework for this, but a wider discussion with the community is needed to agree on a way of doing (use patron_autocomplete? Use existing patron search modal in vuejs?) > > 9. Hmmm I turned off "Checkin" for the CPL institution but it still let me > checkin... maybe it does require a restart. I'll re-test that... > > Hmm nope... still allows checkin after a restart of the SIP server. > > Although to be fair I don't know if any of those attributes ever worked in > SIPconfig.xml either. I've looked here and these seem to not be working, even before this piece. It doesn't matter if checkin/checkout if 'true', 'false', or non-existent, it always allows for checkin/checkout. I thought it could be because I was testing checkin/checkout for cardnumber '42' (superlibrarian) but using a regular patron produces the same results. I'd consider this to be a bug outside the scope of this work. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
