https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893
--- Comment #55 from Pedro Amorim <[email protected]> --- (In reply to Kyle M Hall (khall) from comment #54) Thank you so much for your time looking here, Kyle. > For the institutions editor: > It appears that deleting an institution will delete all accounts connected > to that institution ( which makes sense ) with no warning. It would be best > if the editor either warned that "the following accounts will be deleted: > act1, act2, etc." or simply prevent deletion of institutions with SIP > accounts. Considering this non-blocker, I hope you understand and agree, for the following reasons: 1) A confirmation box already exists. 2) Only authorized staff members with assigned permissions are able to delete institutions in the first place. 3) This needs a framework doResourceDelete change (i.e. may need additional testing / cause a QA delay here). For that, I've opened bug 41178, and provided patches there. I don't think full module should be blocked by this, and ideally bug 41178 is also looked at by Matt+Joubu. > It would also be nice if the institution "name" field were limited to a > branchcode pulldown since Koha can no longer handle institutions that are > not branchcodes. This is a bit out of scope so it's not a blocker. At the > very least the tooltip should state that unexpected behavior can occur if it > is *not* a valid branchcode. Not a blocker. Opened bug 41180 for future enhancement. Patch updating the tooltip pushed to branch: https://github.com/openfifth/koha/commit/3ecf278a05ed4dc96e0d104ce0d91ce6626a98ac > The policy defaults should all default to "yes" in my mind, but I'm open to > arguments against it. Patch submitted: https://github.com/openfifth/koha/commit/0278df6b9575846c4b67fbae0619cbbe4dd56d94 > Retries field should be limited to a max of 999 retries, as the field is 3 > characters long. This is a blocker and a minor fix I think. Patch submitted: https://github.com/openfifth/koha/commit/24393d6d0b46a976f358673ebda9af37f8d059dd > "Staff userid for SIP2 authentication" could be using the patron search in > the same way that circulation does to fill in the userid from a list of > options. Also not a blocker but would be really nice to have. Not a blocker. Opened bug 41179 for future enhancement. > For the accounts editor: > "Convert nonprinting characters" defaults to NULL for imported accounts, but > defaults to empty string for created accounts with no option for NULL. The > only value I've ever used for this is a space, as it is usually used to > convert things like newlines for devices that cannot handle them. This could > be either changed to a text field with a checkbox, or a pulldown with > options for NULL and space ( and could be added to in the future ), or even > a list of authorized values. The simplest solution would be to have empty > string convert to NULL. Any of these solutions is acceptable IMO. Patch ensure empty string is submitted as NULL: https://github.com/openfifth/koha/commit/95e718520f2d9a3bff1f2ed12e2d735b925806c7 > "Format due date" should have a tooltip explaining it will format the due > date in the current DateFormat syspref. Patch updating tooltip: https://github.com/openfifth/koha/commit/6d3373f7ce0565c44a7dda9c78b7ec2fd8e87466 > "Holds get captured" may need a tool tip? Not a blocker, but I'm not sure > how well understood this one will be. Patch updating tooltip: https://github.com/openfifth/koha/commit/8a59f8935ca82975f5a24a2d849d157bb352e2f3 > "Previous checkout block checkout" should read "Block checkout of items > previously or currently checked out by a patron", or maybe "Block previous > checkouts" with a tooltip since that is quite verbose. Patch updating label+tooltip: https://github.com/openfifth/koha/commit/019a5d6a511631f793e083ac292b1772fe04296d > "Send patron home library in AF" can be deprecated but is totally out of > scope for this bug. It was for Overdrive but they no longer use this feature > ( though we'll need to verify they don't have legacy customers using it if > we do ). They now use custom fields of the patron's branchcode. No action made here. I'll leave it up to you if you feel necessary to open a new bug for this or not. > Terminator should default to CRLF. Patch defaulting terminator to CRLF in form: https://github.com/openfifth/koha/commit/412003aeb35d3b5096098d342d0544fa9406ad20 > Patron attribute could use a pulldown of attribute types. Could use a > tooltip at the least. Opened bug 41181 for future enhancement. Patch updating field tooltip in form: https://github.com/openfifth/koha/commit/81408e0c1dfd54d74aa49ed68001a3a4f41c2d5a > It would be nice if delimiter, encoding and terminator had the defaults > inserted into the database instead of being NULL in the database and showing > as empty cells in the accounts table. Patch defaulting delimiter and terminator inserted values in database: https://github.com/openfifth/koha/commit/53670bebfd78bf2eac2ee51ae131f38a38483ca3 encoding was skipped as I'm unsure if it should default to utf or ascii and the code appears to consider NULL as a possibility (?). I'm setting this back to PQA as having addressed the feedback but I'm happy to discuss further and/or revisit anything that needs it. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
