https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893
--- Comment #58 from Jonathan Druart <[email protected]> --- Quick QA review (not tested SIP) 1. There are no cypress tests 2. Only use the plural module is needed eg. 22 use Koha::SIP2::Account; 23 use Koha::SIP2::Accounts; same pattern in several places 3. Tests are missing for (at least) Koha/SIP2/Account.pm Also get_for_config sub are not covered by tests. Not sure how it would be useful however... 4. If I upgrade I do have stuffs in the DB (picked from /etc/koha/sites/kohadev/SIPconfig.xml) but for new installs the table are not populated. Maybe we need to patch miscdev(?) 5. "Cash register:" shouldn't we hide it if none exists or if the pref is off? 6. Framework bugs? a. you can enter a letter after a number ("42a") in the numeric input (eg. "retries") and submit the form and you get a "400 Something went wrong: Error: Expected integer - got string." b. you can enter a letter in the number inputs ('x') and it becomes "NaN" 7 Don't we want a config flag to turn off the ability to edit from the UI? 8. kohastructure.sql has wrong DROP/CREATE statement +DROP TABLE IF EXISTS `file_transports`; +/*!40101 SET @saved_cs_client = @@character_set_client */; +/*!40101 SET character_set_client = utf8 */; +CREATE TABLE `file_transports` ( 9. I think sip2/sip2.tt is wrong about #sip2 being closed in intranet-bottom.inc It should be <div id="sip2"></div> and the last closing div removed. 10. Breadcrumb start with SIP2, shouldn't it be "Administration"? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
