https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680
--- Comment #130 from Victor Grousset/tuxayo <[email protected]> --- Comment on attachment 188127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188127 Bug 40680: Move EXPORT_OK right after Modern::Perl Review of attachment 188127: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=40680&attachment=188127) ----------------------------------------------------------------- ::: C4/Auth_with_shibboleth.pm @@ +155,4 @@ > module => 'members', > letter_code => 'WELCOME', > branchcode => $patron->branchcode, > + Good catch here with the double ,, and another instance of the same. Ew that these things compiled <.< ::: C4/Members/Messaging.pm @@ +25,5 @@ > + our @EXPORT_OK = qw( > + GetMessagingPreferences > + SetMessagingPreference > + GetMessagingOptions > + SetMessagingPreferencesFromDefaults In the whole patchset, that's the only change for that file. Is that expected that there was no proper export before? Introducing it should not cause any issues to the current callers of these methods, right? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
