https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680
--- Comment #132 from Jonathan Druart <[email protected]> --- (In reply to Victor Grousset/tuxayo from comment #130) > Comment on attachment 188127 [details] [review] > Bug 40680: Move EXPORT_OK right after Modern::Perl > ::: C4/Members/Messaging.pm > @@ +25,5 @@ > > + our @EXPORT_OK = qw( > > + GetMessagingPreferences > > + SetMessagingPreference > > + GetMessagingOptions > > + SetMessagingPreferencesFromDefaults > > In the whole patchset, that's the only change for that file. Is that > expected that there was no proper export before? Introducing it should not > cause any issues to the current callers of these methods, right? I've noted at least those ones. So either we adjust the callers or we export, it seems that I've decided to add the exports. Koha/CurbsidePickup.pm:use C4::Members::Messaging qw( GetMessagingPreferences ); opac/opac-memberentry.pl:use C4::Members::Messaging qw( SetMessagingPreferencesFromDefaults ); t/db_dependent/Circulation.t:use C4::Members::Messaging qw( SetMessagingPreference ); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
