https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40777

Victor Grousset/tuxayo <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |[email protected]

--- Comment #28 from Victor Grousset/tuxayo <[email protected]> ---
> move the code from the search_for_inconsistencies.pl maintenance script to a 
> module to make it reusable from the Koha UI.

This is great :D


----


Turns out the tests fail if one happens to have started KTD with UNIMARC data.

And if I go to the UI and click audit. Like
http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=1271
(unimarc test data)

I get:

The Framework ** is using the authorised value's category *TYPEDOC*, but the
following biblioitems.itemtype do not have a value defined ({itemnumber =>
value }): {2275 => LIVR}
The Framework ** is using the authorised value's category *LOC*, but the
following items.location do not have a value defined ({itemnumber => value }):
{2275 => Documentaires adulte} 

So it doesn't seems like it's just the tests that have hard coded marc21 data.

------

No POD for subs and the new module.
Though the QA script skips it. Does that mean it's not actually mandated there?
Or is that just because it's too hard given the legacy code everywhere to make
this blocking in the script?
[SKIP] Koha/Database/DataInconsistency.pm
   SKIP   pod_coverage
                No POD exists


----

for_biblio() isn't covered by tests (I mean actual code coverage, not the weird
error message we get in some cases)

In errors_in_marc() the cases "biblio_tag < 10" and "biblioitem_tag < 10"
aren't covered but if it's not trivial I don't think it's a big deal.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to