https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40777

--- Comment #31 from Jonathan Druart <[email protected]> ---
(In reply to Victor Grousset/tuxayo from comment #28)

> Turns out the tests fail if one happens to have started KTD with UNIMARC
> data.
> 
> And if I go to the UI and click audit. Like
> http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=1271
> (unimarc test data)
> 
> I get:
> 
> The Framework ** is using the authorised value's category *TYPEDOC*, but the
> following biblioitems.itemtype do not have a value defined ({itemnumber =>
> value }): {2275 => LIVR}
> The Framework ** is using the authorised value's category *LOC*, but the
> following items.location do not have a value defined ({itemnumber => value
> }): {2275 => Documentaires adulte} 
> 
> So it doesn't seems like it's just the tests that have hard coded marc21
> data.

Looks like incorrect data, it's a misc4dev's problem.

> No POD for subs and the new module.
> Though the QA script skips it. Does that mean it's not actually mandated
> there? Or is that just because it's too hard given the legacy code
> everywhere to make this blocking in the script?
> [SKIP] Koha/Database/DataInconsistency.pm
>    SKIP   pod_coverage
>                 No POD exists

Fixed in the last patch.

> for_biblio() isn't covered by tests (I mean actual code coverage, not the
> weird error message we get in some cases)

Added a test.

> In errors_in_marc() the cases "biblio_tag < 10" and "biblioitem_tag < 10"
> aren't covered but if it's not trivial I don't think it's a big deal.

Yeah, not a big deal :D
And feeling lazy for that right now.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to