https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36067
David Nind <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This updates several release notes| |scripts, cron jobs, and | |files so that they use | |--confirm instead of | |--commit, for consistency | |with other scripts. | | | |Scripts, cron jobs, package | |commands, and files updated | |are: | |- koha-elasticsearch | |- | |misc/cronjobs/crontab.examp | |le | |- | |misc/cronjobs/delete_items. | |pl | |- | |misc/cronjobs/longoverdue.p | |l | |- | |misc/cronjobs/patron_emaile | |r.pl | |- | |misc/link_bibs_to_authoriti | |es.pl | |- | |misc/search_tools/rebuild_e | |lasticsearch.pl | | | |**Important note for | |existing installations**: | |You will need to update | |your crontab files if any | |entries include --commit as | |an option. CC| |[email protected] --- Comment #3 from David Nind <[email protected]> --- Thanks for the patch! The author is currently showing as "John Doe <[email protected]>". If you can let me know the correct details, I'll update the patch author. I think these details are also used for what is shown on More > About Koha > Timeline for new Koha developers (and looks good on your CV!). David Testing notes (using koha-testing-docker): 1. I didn't test the actual scripts to see if they still work - looks like a straight-forward string change to me. 2. Before the patch: git grep "\--commit" 3. Several occurrences. 4. After the patch: only one occurrence left in misc/migration_tools/bulkmarcimport.pl (others are historical release notes) 5. To get `koha-elasticsearch -h` to show the updated help information, do a reset_all after applying the patch. Does misc/migration_tools/bulkmarcimport.pl need updating as well? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
