https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36067
Andrew Fuerste-Henry <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #7 from Andrew Fuerste-Henry <[email protected]> --- The test plan for this bug needs to include actually running all the impacted scripts with both --commmit and --confirm to ensure they both work after the patch is applied. With this patch applied, delete_items.pl works with --commit but not with --confirm. kohadev-koha@kohadevbox:koha(main)$ perl misc/cronjobs/delete_items.pl --where "withdrawn=1" --confirm -v Unknown option: confirm Where statement: withdrawn=1 Test run only! No data will be deleted. Would have deleted item 756 (1 items remain on record) Looking at the code, you've added --confirm to the list of options shown to the user when using --help or --manual, but not actually implemented it in the GetOptions section (https://github.com/Koha-Community/Koha/blob/c3169205eced4a862be39120ea7db82b116e1435/misc/cronjobs/delete_items.pl#L34) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
