https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190
--- Comment #233 from Chloé Zermatten <[email protected]> --- (In reply to Victor Grousset/tuxayo from comment #232) > I got around 28 tests failing. On a ktd started with the patches. And also > when starting on main and upgrading. And with defaultCommandTimeout: 20000 > (that's what is usually needed on my slow laptop) > > Is there something else to do to run the tests besides starting KTD and > running them directly? > cypress run --config video=false --spec > t/cypress/integration/Admin/CirculationTriggers_spec.ts > > Otherwise that looks like a legit failure. For example, for "Should display > correct breadcrumbs", the .current class is indeed not on "Home". > > > --- > > For the next patch version, can the steps to perform an upgrade added to the > test plan? > > From what I have gathered it's: > > sudo perl /kohadevbox/misc4dev/cp_debian_files.pl --instance=kohadev > --koha_dir=/kohadevbox/koha --gitify_dir=/kohadevbox/gitify > yarn build > > But maybe they are wrong. And it took me some time to find about needing > cp_debian_files.pl > > ---------- > > If I want to test the migration of the old triggers. Is there any > interesting data to test? Or do I just put multiple triggers and check that > the most popular stuff is picked as default? > > ------- > > 1. open the form "Confirm trigger context" > 2. click on the "Patron category" list > 3. try to scroll because you aren't finding the desired category > 4. It barely scrolls. > > You have to thing about moving the mouse outside of the list and scroll > there. > If the size of the things lines up enough, when trying to scroll you don't > get to see the beginning of the next patron category. So you can really > think the list is 3 or 4 elements long and that's all. I almost reported > that the list was incomplete instead of reporting this. > > ------ > > When not logged into Koha and going to > http://localhost:8081/cgi-bin/koha/admin/circulation_triggers > One is redirected to the login page. > After login, the redirection is done to > http://localhost:8081/cgi-bin/koha/admin/circulation_triggers.pl > Which isn't valid and goes 404. > I though I missed some setup step at some point. But it was just an invalid > redirect. > Maybe it's from the rewrite rule in > debian/templates/apache-shared-intranet.conf Hi Victor, Many thanks for the feedback! I have a few UI/UX and permission fixes in the work (which includes dropdown select / scroll behaviour improvements, and should address what you've reported here), working from testing feedback from Michaela, and I'm aiming to resubmit by Friday this week. I'll be taking a look at the failing cypress tests as well. For data migration testing, what you've described is in effect what I have done. I haven't stumbled upon any particular edge case that needs looking into. The login/redirect fail: I'll need to look into that one. What I can say is the URL needs to be http://localhost:8081/cgi-bin/koha/admin/circulation_triggers, not http://localhost:8081/cgi-bin/koha/admin/circulation_triggers.pl. I'll see if the RewriteRules can help resolve this. I did find the new circulation triggers RewriteRule was missing from etc/koha-httpd.conf (fix not submitted yet - another one for Friday!) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
