https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190
--- Comment #238 from Chloé Zermatten <[email protected]> --- (In reply to Victor Grousset/tuxayo from comment #236) > qa script is finding various issues. Like tidy, spelling, filters, > permissions. All minor stuff. > > Tidy stuff might be a pain, we shouldn't use tidy commits anymore, it should > be done inline. If the untidy stuff comes from many commits (maybe old > commits were done on a machine without the git hook that should tidy > automatically), then it would be bad to have all the fixes in the last > commit. > If that's the situation, it might work to do an interactive rebase and mark > all commits for "edit". Then amend them one by one without any change, but > it should trigger the tidy hook. Hopefully that doesn't start doing tons of > conflicts if commits touch the same places that were untidy. In that case, I > think it would be a ok have tidy commit. The history on main shows there are > a very few other tidy commits. So we can sneak another one if that's needed > to fix an old mess without being a total pain. > > Hope that helps. > > > ---- > > > Code coverage is good, whether on new code and changes being covered. And on > test removal not removing coverage on any still existing code. Currently working my way through said issues, and I've got a quick question on one of them if that's alright: [FAIL] koha-tmpl/intranet-tmpl/prog/js/vue/stores/circulation-rules.js FAIL forbidden_patterns forbidden pattern: Use __("") instead of _("") (line 35) seems to have been triggered by this regex: /overdue_(\d+)_has_rules/. Would that be a case of the qa script picking up on something it shouldn't? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
