https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41768

David Cook <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #10 from David Cook <[email protected]> ---
(In reply to Arthur Suzuki from comment #9)
> (In reply to David Cook from comment #8)
> > Hmm the OPAC does need to use /public endpoints, but I don't know about the
> > staff interface using /public endpoints. 
> > 
> > But then should there be duplicate endpoints across the interfaces? 
> > 
> > (It's a shame we have /public endpoints rather than /admin endpoints as that
> > would make the distinction clearer.)
> 
> I don't think staff interface should need a specific "admin" endpoint when a
> "public" endpoint does the job and serve the purpose.
> And I think this "pickup_locations" endpoint should definitely be public
> rather than private!

I think that you're misunderstanding what I'm saying. I probably wasn't clear
enough.

What I meant was that most of our endpoints are "/admin" endpoints but we don't
label them like that. 

Instead, we labelled normal endpoints as "/public". 

--

At some point, we might need to look at changing/removing the system
preferences RESTPublicAnonymousRequests and RESTPublicAPI which can be used to
cripple the OPAC which uses the /api/v1/public endpoints...

If you did use that /public endpoint and someone had RESTPublicAPI set to
disable, then holds wouldn't work anymore in the staff interface, right?

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to