https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41768
--- Comment #15 from David Cook <[email protected]> --- (In reply to Arthur Suzuki from comment #14) > (In reply to David Cook from comment #13) > > That said, note that so far public API endpoints are only used in OPAC. > > They're not used in the staff interface. I think this one needs to be > > discussed with other devs. > > well, given the public endpoints are used in the OPAC I'd say they are quite > mandatory. Yep, I would agree with you there. Hence my comment about those 2 system preferences being a problem. > That being said, I don't see any good reason why the staff interface should > not use a public endpoint. Yeah, you might have a point. I'm working on a different bug where someone added a public endpoint to be used for both the staff interface and the OPAC. I'm not sure what I think of it yet. On one hand, having admin and /public endpoints separate allows for a clear separation of concerns. On the other hand, if the endpoint is going to be used exactly the same in both interfaces, then surely it would make sense to just have one endpoint. That being said, I thought pickup locations were scoped to individual users. Indeed if you look at Koha/REST/V1/Biblios.pm you can see that it takes a patron_id and public endpoints shouldn't allow people to provide a patron_id. It would need to take the logged in user's patron_id. So it would need to be a different endpoint. > Why would we want to duplicate an endpoint with the same results/data? > (imo, we should not duplicate, that leads to confusion) You mean like the following? /api/v1/public/libraries/{library_id} /api/v1/libraries/{library_id} /api/v1/public/items /api/v1/items /api/v1/public/oauth/login/{provider_code}/{interface} /api/v1/oauth/login/{provider_code}/{interface} -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
