https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16631

--- Comment #140 from Casey Conlin - mattermost @Casey246 
<[email protected]> ---
(In reply to Andrew Fuerste-Henry from comment #139)
> After some discussion and contemplation, I'm happy to walk back most of my
> thoughts about how this should work differently. A lot of this will change
> with the upcoming permissions rewrite, but this is a great step in the right
> direction and will be helpful in the meantime.
> 
> Two things that do need to change:
>  - Where you've used the term "branch," you should instead use "library"
> (https://wiki.koha-community.org/wiki/Terminology)
> 
>  - When the LimitReportsByBranch system preference is enabled, reports
> created by users without manage_report_limits permission should default to
> being limited to the library of the user

Thanks for this, Andrew. 
The first item is straightforward, and we'll implement it. 

Regarding the second item, I wanted to try to clarify the expected behavior.
- When the system preference is initially enabled, should the availability of
existing reports change for users? The current behavior is a large pool of
shared reports all users can see, but in the proposed behavior it sounds like
by default reports would be "private" to a user's home library. 
  - When a user with permissions enables the system preference, would most of
the reports disappear for most users? 
  - Or would the existing pool of reports still be there, available to everyone
until a user with the manage_report_limits permission changes it?

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to