https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16631
--- Comment #141 from Casey Conlin - mattermost @Casey246 <[email protected]> --- (In reply to Andrew Fuerste-Henry from comment #139) > After some discussion and contemplation, I'm happy to walk back most of my > thoughts about how this should work differently. A lot of this will change > with the upcoming permissions rewrite, but this is a great step in the right > direction and will be helpful in the meantime. > > Two things that do need to change: > - Where you've used the term "branch," you should instead use "library" > (https://wiki.koha-community.org/wiki/Terminology) > > - When the LimitReportsByBranch system preference is enabled, reports > created by users without manage_report_limits permission should default to > being limited to the library of the user One more thing, this time on renaming "branch" to "library". Would that change be mostly for user-facing UI? Like: 1. “My branch reports” to “My library reports” 2. “Show my branch reports” to “Show my library reports” 3. Any other visible “branch” wording introduced by this patch Or would we want to rename things that happen "behind the scenes" in the code, too? Like: 1. LimitReportsByBranch 2. reports_branches 3. branchcode 4. mybranch 5. function parameters/relationship keys that already use branch `branch` seems to be used a lot in the koha repo for things like `branchcode`, `mybranch`, `branchname`, etc. Keeping my variable and functions as `branch` seems like it would be more consistent with the rest of the repo, but if we're trying to shift away from this, I can work `library` in place of `branch`. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
