https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501
David Nind <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #33 from David Nind <[email protected]> --- As I haven't done anything with lists for a while, I got myself very confused. For a staff list (that is, a list named "List C - Staff", with "Public" = "Staff only"), none of the "Allow changes to contents from" options let me view or edit the list in the staff interface for Staff user B (I used Henry and gave catalogue and all the list permissions). Staff user B (Henry) could see the list under "Staff lists", but when you try to access the list you get "You do not have permission to view this list.". As an aside, the label "Public" when creating lists is confusing (to me, anyway). It made slightly more sense when the there were only two options (Private and Public). Maybe it should be "Who can view this list" or "List visibility". The tests failed for me (see below). Testing notes (using KTD): 1. Things I tested: - I created three lists and added some records (using the koha patron (Staff user A): . List A - Private (Public = Private) . List B - Public (Public = Public) . List C - Staff (Public = Staff) - For Staff user B, I used Henry and gave catalogue and all list permissions. - The results from different "Allow changes to contents from" for Staff user B (Henry): . For the staff interface: . Nobody: can see list in the list of staff lists, but can't view what is in it "You do not have permission to view this list." . Owner only: same as "Nobody" . Permitted staff only: same as "Nobody" and "Owner only" . Staff only: same as "Nobody", "Owner only", and "Permitted staff only" . Anyone seeing the list: same as "Nobody", "Owner only", "Permitted staff only", and staff only . For the OPAC: the results are consistent and as expected (?), Henry can't see the list for any of the options (in either the Lists dropdown or lists section of account). Note: the "Owner" (koha) can see it in the OPAC. 3. Notes for myself: "Public" controls where the list will appear and who will see it: - Private: only viewable by the owner in the staff interface and OPAC - Public: viewable by everyone in the staff interface and OPAC - Staff only: only viewable by staff in the staff interface and OPAC "Allow changes to contents from" controls who can make changes to the list: - Nobody: nobody can see the list apart from a superlibrarian - Owner only: only the person who created the list (recorded as owner) can make changes - Permitted staff only: only staff with - Staff only - Anyone seeing the list 4. The tests fail: prove t/db_dependent/Virtualshelves.t t/db_dependent/Virtualshelves.t .. 8/11 # Failed test 'Our two public lists are returned' # at t/db_dependent/Virtualshelves.t line 1608. # got: '1' # expected: '2' # Looks like you planned 4 tests but ran 3. # Looks like you failed 1 test of 3 run. # Failed test 'filter_by_public() tests' # at t/db_dependent/Virtualshelves.t line 1615. # Looks like you failed 1 test of 11. t/db_dependent/Virtualshelves.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/11 subtests Test Summary Report ------------------- t/db_dependent/Virtualshelves.t (Wstat: 256 (exited 1) Tests: 11 Failed: 1) Failed test: 9 Non-zero exit status: 1 Files=1, Tests=11, 5 wallclock secs ( 0.04 usr 0.01 sys + 3.79 cusr 1.25 csys = 5.09 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
