https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42719

--- Comment #2 from Tomás Cohen Arazi (tcohen) <[email protected]> ---
Created attachment 199695
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199695&action=edit
Bug 42719: Handle missing CGISESSID in OAuth login (IdP-initiated flow)

When a user initiates login from the IdP (e.g. Okta app tile), they
hit the OAuth endpoint without an existing session cookie. The code
crashed calling ->value on an undefined cookie object.

This patch:
- Creates a session on-the-fly for the initial request when no
  cookie exists (IdP-initiated flow)
- On callback, redirects with wrong_csrf_token error instead of
  crashing when the cookie is missing

CSRF protection is preserved: the state token is bound to the
session created in the initial request, and the browser returns
the cookie on callback for validation.

Signed-off-by: Tomás Cohen Arazi <[email protected]>

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to