https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42663

--- Comment #24 from Jonathan Druart <[email protected]> ---
(In reply to David Cook from comment #23)
> (In reply to Jonathan Druart from comment #22)
> > (In reply to David Cook from comment #20)
> > > Error: Apply failed: Git command (git am -3
> > > /tmp/65T3f7nUOu/0001-199372.patch) failed: error: sha1 information is
> > > lacking or useless (C4/Auth.pm).
> > > error: could not build fake ancestor
> > > hint: Use 'git am --show-current-patch=diff' to see the failed patch
> > 
> > The whole tree still applies for me, I've update the remote branch
> > https://gitlab.com/joubu/Koha/-/commits/bug_42663
> 
> I just fetched https://gitlab.com/joubu/Koha and e2ef34cb580 does represent
> a C4/Auth.pm state there, and it looks like the problem was I must not have
> applied the dependencies. I don't recall git-bz prompting to apply them.
> Hmm...

perl-git-bz apply patches from bug reports "in discussion" only since a couple
of weeks. You need to pull.

> I don't really understand the dependency list here to be honest. For
> instance, bug 41896 is listed as a dependency, but it doesn't appear to be
> relevant here? 
> 
> Since bug 41896 is the only one that is really moving along, wouldn't it
> make more sense to remove the dependencies and then make them depend on bug
> 42663? I know it's a PITA from a coding perspective, but from a testing
> perspective it would make way more sense.

Indeed we don't directly need bug 41896 here. However I don't understand what
you are suggesting. Bug 42663 is supposed to be the next step (move to OOP)
once the first one (remove circ deps) is pushed.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to