https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20955
--- Comment #32 from David Cook <[email protected]> --- Workarounds... in C4::Circulation::AddReturn we do the following: my ( $resfound, $resrec ); my $lookahead = C4::Context->preference('ConfirmFutureHolds'); #number of days to look for future holds ( $resfound, $resrec, undef ) = C4::Reserves::CheckReserves( $item, $lookahead ) unless ( $item->withdrawn ); # FIXME: CheckReserves should return the Koha::Hold my $hold = Koha::Holds->find( $resrec->{reserve_id} ); # if a hold is found and is waiting at another branch, change the priority back to 1 and trigger the hold (this will trigger a transfer and update the hold status properly) if ( $resfound and $resfound eq "Waiting" and $branch ne $resrec->{branchcode} ) { $hold->revert_found(); $resfound = 'Reserved'; $resrec = $hold->unblessed; } if ($resfound) { $resrec->{'ResFound'} = $resfound; $messages->{'ResFound'} = $resrec; } -- Technically, C4::Reserves::CheckReserves does return 3 values in most cases: return ( "Waiting", $res, \@reserves ); return ( "Processing", $res, \@reserves ); return ( "Transferred", $res, \@reserves ); return ( "Reserved", $highest, \@reserves ); It's only if there is no $highest set that we return nothing. So maybe... what we can do is if "AllowHoldPolicyOverride" is set to allowed... we return the possible reserves and present the top 5 or something to the staff member and they can decide which hold the item should fill? -- But... the problem with that is that it assumes that there's no other holds that this item could fill. It might be that the next hold to fill is a forbidden hold but the other holds in the queue after it are allowed holds. This would never work for that scenario. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
