https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42873
--- Comment #5 from Martin Renvoize (ashimema) <[email protected]> --- 1. It's a new module I wrote after profiling.. it does two things under the hood.. * Changes how we parse the XML from DOM to Reader * Skips validation on MARC::Field->new which is called in a loop in MARC::File::XML from MARC::Record.. it's safe to do so in our case after bug 35104 as we should be strongly blocking bad data getting into the database.. however we still catch just in case and fall back to the older method of ->from_marcxml which includes the validation. I'm just opening a discussion with Galen to look at upstreaming it into Marc::Record itself or releasing a new compatible distro on cpan under the same namespace. - https://github.com/mrenvoize/MARC-File-XML-Fast For this bug, I've actually included it as a vendored version under /lib so we don't have to wait for the results of my upstream discussions or packaging efforts. 2. I'm just in the habbit of putting things behind preferences.. your right, it's probably completely superflous. As a side note.. I didn't get quiet as much performance boost as I wanted yet.. iniital intention was to consider an XS or Platypus rust module which gives bigger wins but really we need some of these bits first before the parser side makes much impact. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
