https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42873

--- Comment #6 from David Cook <[email protected]> ---
Comment on attachment 200619
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200619
Bug 42873: Add UseFastMARCDecode system preference

Review of attachment 200619:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=42873&attachment=200619)
-----------------------------------------------------------------

::: installer/data/mysql/atomicupdate/bug_42873.pl
@@ +9,5 @@
> +        my ( $dbh, $out ) = @$args{qw(dbh out)};
> +
> +        $dbh->do(
> +            q{
> +                INSERT IGNORE INTO systempreferences (variable, value, 
> options, explanation, type)

Do we want to default to 1?

Also, what's our stance on providing "options, explanation, type" columns on
patches for main?

::: installer/data/mysql/mandatory/sysprefs.sql
@@ +887,4 @@
>  ('UseCirculationDesks','0'),
>  ('UseControlNumber','0'),
>  ('UseCourseReserves','0'),
> +('UseFastMARCDecode','1'),

Isn't this one in the wrong spot? I think sysprefs.sql is supposed to be sorted
alphabetically?

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to