https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37502

--- Comment #24 from David Nind <[email protected]> ---
(In reply to Adolfo Rodríguez Taboada from comment #22)
> Created attachment 201266 [details] [review]
> New version of the patch with tidied up files
> 
> Thanks for the sign-off, David!
> 
> Regarding your comments:
> 
> Tab counter (ERM (1) with multiple packages): This is intentional. The
> number shown in the tab label reflects the count of ERM titles linked to the
> bibliographic record, not the number of packages. A single title can appear
> in multiple packages, but what we are exposing here is the title-level link
> — so "ERM (1)" correctly means one ERM title is associated with this biblio.
> This design decision was deliberate.
> 
> Tidiness failures: Fixed. The four files flagged by the QA script
> (Koha/REST/V1/Biblios/ERMHoldings.pm, catalogue/detail.pl,
> catalogue/detail.tt, ERMCatalogueTab.vue) have been run through
> misc/devel/tidy.pl and the changes incorporated into the patch. A new
> version of the patch has been uploaded.
> 
> Bug 42933: Agreed that this falls outside the scope of this bug. Bug 37502
> is specifically about exposing ERM holdings information in the catalogue
> detail view. The behaviour you described in Bug 42933 is a separate concern
> and should be addressed there.
> 
> Greetings, Adolfo.

Thanks Adolfo!

I couldn't figure out how to get multiple titles to link to the bibliographic
record (as shown in the original image attached to the bug).

Some steps on how to do that would be appreciated (partciularly for the
documentation update needed later on).

David

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to