https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38196
--- Comment #8 from Jan Kissig <[email protected]> --- (In reply to David Nind from comment #6) > (In reply to Jan Kissig from comment #4) > > > Hey David thank you for testing this. > > Are the TICKET_STATUS AVs named like 'Option 1' or 'Option1'. I just found > > that having a white space in an AV the filters don't work. Maybe this > > already solves the problem for testing. > > As AVs may contain spaces (more than 50 in the db contain one), I have to > > fix that patch to make these working too. > > I can confirm that I had spaces in the authorised values. > > I retested without spaces in the "Authorized value" field value (and with > and without your patch), so OPTION1, OPTION2, OPTION3, and OPTION4, > (description fields are "Option X" and so on), I get quite "weird" results. > > Created six catalog concerns: > - Concern 1: Open (no status assigned) > - Concern 2: Resolved > - Concern 3: OPTION2 (Option 2) > - Concern 4: OPTION3 (Option 3) > - Concern 5: OPTION2 (Option 2) > - Concern 6: OPTION1 (Option 1) > > What I expected: > 1. Going to the page the first time: all catalog concerns are shown > (open, different statuses, resolved) > 2. Clicking on "Filter resolved": any resolved catalog concerns are > not shown (maybe the label should be "Filter out resolved [concerns]") > 3. Clicking on "Include resolved": all catalog concerns are shown again > 4. Clicking on any of the "Filter XXXX" filters: only shows the catalog > concerns with that status > > What I see with the patches: > - 1 to 3 above: works as expected > - 4: get "weird" results - I expected clicking on the filter would show > only those with that status, instead: > . Filter Option 1 (OPTION1): clicking filters out the catalog concern > with > "Option 1" as the status, includes resolved > (5 concerns listed) > + Include Option 1: shows all catalog concerns (6) > . Filter Option 2 (OPTION2): clicking filters out the 2 catalog concern > with > "Option 2" as the status, includes resolved > (4 concerns listed) > + Include Option 2: shows all catalog concerns (6) > . Filter Option 3 (OPTION3): clicking filters out the catalog concern > with > "Option 3" as the status, includes resolved > (5 concerns listed) > + Include Option 3: shows all catalog concerns (6) > . Filter Option 4 (OPTION4): clicking shows no change, as there are no > catalog concerns with "Option 4" as the > status, > includes resolved > (6 concerns listed) > + Include Option 4: shows all catalog concerns (6) > > From someone new to this area, I would expect clicking on the filters for > the > different statuses to only show the catalog concerns that match that status. > > It seems totally unintuitive to me the way that it is now. > > Outside the scope of this bug, but this seems a totally different user > interface design than used elsewhere. A common model is using tabs with the > different status, rather than filters. > > So, I'm not sure where to go from here.... > 1. I think how it is shown now (both before and after the patch) is not > what a "normal" staff member would expect: > filter/only show catalog concerns that match this status (rather > than filtering them out!) > 2. Your bug does what it says it will (now including resolved concerns in > the > list), that is, shows all catalog concerns excluding the status shown in > the > filter name > 3. I don't work in a library, so not sure what the workflow would be > for managing concerns You are right, the behavior of these filters is somehow opposing how filters are used elsewhere in Koha. Instead of naming it "Filter ..." it should be named "Hide ..." and then the behavior would make much more sense. As the opposing option to "Filter" is "Include", it seems that the intention of the creator of that feature was that it works like it is now. That means Filter will filter out the value that was clicked. Without the patch f.e. filtering for OPTION3 removed OPTION3 and (the bug) also resolved and opened tickets. And this gets fixed by the patch. Also Joubus bug description draws in that direction. Would you think it is sufficient to rename "Filter" to "Hide" for all Buttons above the table? A complete rewrite to change the behavior to a more intuitive pattern could be done in a separate bug then. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
