https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42915
--- Comment #37 from David Cook <[email protected]> --- Comment on attachment 201917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201917 Bug 42915: Use coded value for library filtering in holds table Review of attachment 201917: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=42915&attachment=201917) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/js/holds.js @@ +105,4 @@ > }; > })(jQuery); > > +var coded_values = { You almost never want to be declaring a global variable like this in a Javascript file. The reason it's a problem here is because this variable gets set *before* all_libraries even gets defined. I imagine in the first version when all_libraries got set in holds_table.inc it probably worked and then it broke when it was moved to requests.tt. Putting it into a a ready() functoin or DOMContentLoaded event handler would've been a lot better. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
