https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42915
--- Comment #38 from Martin Renvoize (ashimema) <[email protected]> --- Created attachment 202968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202968&action=edit Bug 42915: (QA follow-up) Defer coded_values declaration until document ready holds.js declared `coded_values` as a bare top-level global, evaluated immediately at script-parse time, reading `all_libraries` which is only ever defined by the including template (request.tt, or patron-detail-tabs.inc for circulation.tt/moremember.tt). This works today only because those templates happen to emit their `all_libraries` script block before Asset.js("js/holds.js") in the rendered HTML - a fragile, easy-to-break ordering dependency between separate template files, not something holds.js itself can guarantee. Move the assignment into the existing $(document).ready() handler, setting it explicitly on `window` so it remains visible as a global to datatables.js's build_query(), which reads `coded_values` unqualified. This defers evaluation until all synchronous inline scripts (including whichever template defined all_libraries) have already run, regardless of future include/ordering changes. To test: 1. Place holds on a title for two different pickup libraries 2. Confirm the holds table on reserve/request.tt, the patron's Holds tab (circulation.pl and moremember.pl) all load with no console errors 3. Confirm filtering the holds table by pickup library name/branchcode still works on all three pages -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
