http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807

--- Comment #17 from Galen Charlton <[email protected]> ---
Comment on attachment 20988
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20988
[SIGNED-OFF] Bug 10807: Add an authority search history for the OPAC

Review of attachment 20988:
 --> 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10807&attachment=20988)
-----------------------------------------------------------------

For follow-up.

::: C4/Search/History.pm
@@ +1,2 @@
> +package C4::Search::History;
> +

Why not Koha::Search::History since it's a new module?

::: installer/data/mysql/kohastructure.sql
@@ +1879,4 @@
>    `sessionid` varchar(32) NOT NULL, -- a system generated session id
>    `query_desc` varchar(255) NOT NULL, -- the search that was performed
>    `query_cgi` text NOT NULL, -- the string to append to the search url to 
> rerun the search
> +  `type` varchar(255) NOT NULL DEFAULT 'biblio', -- search type, must be 
> 'biblio' or 'authority'

varchar(255) is too wide for this if the only values are either 'biblio' or
'authority'.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to