https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391
--- Comment #291 from Martin Renvoize (ashimema) <[email protected]> --- Created attachment 205877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205877&action=edit Bug 31391: (QA follow-up) Add missing test coverage for hold-to-recall conversion Two code paths introduced by this bug had no direct test coverage: - C4::Reserves::ModReserve's title-level branch of the new `rank => "recall"` conversion (only the item-level branch was tested). - The `hold_convert` bypass in Koha::Item::can_be_recalled, which skips the "patron already has a hold on this item" check so an existing hold can be converted to a recall for the same patron. No production code changes here, coverage only. Test plan: 1) prove t/db_dependent/Holds.t t/db_dependent/Koha/Item.t - all pass 2) Confirm the new tests actually exercise the code they claim to: reverting the `unless ( $params->{hold_convert} )` guard in Koha/Item.pm locally makes the new Item.t subtest fail, as expected. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
