https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391
--- Comment #290 from Martin Renvoize (ashimema) <[email protected]> --- Created attachment 205876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205876&action=edit Bug 31391: (QA follow-up) Fix UseRecalls check in Transfers REST controller UseRecalls was converted from a YesNo syspref to a Choice preference ("off"/"opac"/"staff"/"opac_and_staff") earlier in this bug, and every call site was updated from a truthy check to `ne "off"` - except this one. Since even the string "off" is truthy in Perl, the guard in Koha::REST::V1::Transfers::cancel was silently defeated: cancelling a transfer via the REST API always attempted to revert an in-transit recall, even with recalls disabled. Test plan: 1) prove t/db_dependent/api/v1/transfers.t - new subtest 'cancel() - UseRecalls disabled' fails against the old code (the in-transit recall gets reverted even though UseRecalls is off) 2) Apply this patch 3) Same test now passes -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
