https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42810

Pedro Amorim (ammopt) <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]
                   |                            |k

--- Comment #18 from Pedro Amorim (ammopt) <[email protected]> ---
There is a regression here:
1) Before applying the patch, visit:
 
http://localhost:8081/cgi-bin/koha/admin/categories.pl?op=add_form&categorycode=PT
2) Scroll to 'Account expiry and self-renewal'
3) Click 'New' next to 'Self-renewal information message' twice
4) Confirm there are 3 message fields and the hint 'Information to be displayed
to the patron at the start of the renewal process...' is shown once
5) Apply Owen's patch, then hard refresh the page (or use a private window)
6) Repeat 2) and 3)
7) Confirm the hint is now repeated under every message field (3 times)

It appears the patch is doing more than just fixing the issue, could we split
this work?

- This bug: just the fix. I've attached an alternative patch that changes the
[] to [""] on line 55 of admin/categories.pl (the
self_renewal_information_messages fallback for new categories), which should be
enough.
- A new bug, depending on this one: the grid conversion, the JS rework and the
shared .fg CSS changes.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to