https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42769
--- Comment #33 from Martin Renvoize (ashimema) <[email protected]> --- Created attachment 208469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208469&action=edit Bug 42769: (QA follow-up) Let the SIP2 tester ask for a detail in a patron information request A patron information request asks for one list of items in the response with the summary field: the holds, the overdue items, the charged items, the fines, the recalls or the unavailable holds. The tester always sent ten spaces, so none of the lists was ever in the response. That left out the template of the account that formats the fines (AV), one of the templates this tool is meant to check, and it could only be reached by editing the raw request and knowing which of the ten places stands for the fines. - Add a "Detail" choice to the patron information message: None, which is what was sent before, or one of the six lists. The server reads the first Y only, so one choice is the right shape, and the request gets a Y in the place of the one that is picked. - Add the same choice to the API as the optional summary, one of hold_items, overdue_items, charged_items, fine_items, recall_items or unavailable_holds, and to Koha::SIP2::MessageTester. - Test that the fines, formatted with the template of the account, are in the response with the fine items and not without them, where the Y goes for each of the six, and that the choice in the form builds the request. To test: 1) prove t/db_dependent/Koha/SIP2/MessageTester.t 2) prove t/db_dependent/api/v1/sip2_account_test_message.t 3) yarn js:build, then run t/cypress/integration/SIP2/AccountTester.ts Signed-off-by: Martin Renvoize <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
