https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42769
--- Comment #29 from Martin Renvoize (ashimema) <[email protected]> --- Created attachment 208465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208465&action=edit Bug 42769: (QA follow-up) Fix error handling and accessibility in the SIP2 account tester - Show the error when the account cannot be loaded, and a loading message. The error was rendered inside the block that needs the account, so a failed load left a blank page. - Check that the response has the expected shape before rendering it, and unwrap the "Error: " prefix the http client adds to messages. - Make the "Test SIP2 messages" toolbar button a route link, so it is focusable, has an href and can be opened in a new tab. It is still only shown to librarians who may test messages. - Refuse a "|" in the patron barcode, item barcode and password and disable the Run button: the delimiter would add fields to the generated request. - Build a fresh timestamp when resetting to the generated request. - Mask the patron password field, announce errors and results to assistive technology ( role="alert", aria-live ). - Use the imported $__ in sip2-fields.js and drop the unused getSIPFields and router leftovers from SIP2AccountResource.vue. - Reword the page text: plugin hooks still run and tests are logged. - Add a Cypress spec for the tester. To test: 1) yarn js:build 2) Run t/cypress/integration/SIP2/AccountTester.ts and t/cypress/integration/SIP2/Accounts.ts Signed-off-by: Martin Renvoize <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
