https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43444
Martin Renvoize (ashimema) <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #11 from Martin Renvoize (ashimema) <[email protected]> --- QA: Passed. - Confirmed the issue also affects main, not just 26.05: local_referer() does not strip logout.x there either, so changelanguage.pl redirects back to mainpage.pl?logout.x=1. - Note for testers: staffClientBaseURL (or OPACBaseURL) must match the URL you browse from, otherwise local_referer() falls back to '/' and the problem cannot be seen (this is likely why it could not be reproduced on main in comment 7). - The original patch no longer applied to main (bug 43540 changed Navigation.pm/Navigation.t), so I have attached a rebased version. Only change: the plan count in t/Koha/Util/Navigation.t is now 18. - t/Koha/Util/Navigation.t passes, koha-qa.pl passes, and checked live in KTD with the patch applied: referer mainpage.pl?logout.x=1 -> /cgi-bin/koha/mainpage.pl referer catalogue/search.pl?q=perl&logout.x=1&language=de-DE&x=2 -> /cgi-bin/koha/catalogue/search.pl?q=perl&x=2 - No regressions found; other query parameters are preserved. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
