https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43444
--- Comment #12 from Martin Renvoize (ashimema) <[email protected]> --- Created attachment 208939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208939&action=edit Bug 43444: Remove logout.x from referer When a librarian logs out of the staff interface, the page they land on has the URL mainpage.pl?logout.x=1. After logging in again from that page the URL still contains logout.x=1, so the language links in the bottom bar are followed with that URL as the referer. changelanguage.pl then redirects back to mainpage.pl?logout.x=1 instead of showing the interface in the chosen language. Koha::Util::Navigation::local_referer now strips the logout.x parameter from the local referer, keeping the rest of the path and query intact. To test: 1. Install a second language (e.g. koha-translate --install de-DE) and enable it in the StaffInterfaceLanguages system preference. 2. Make sure the staffClientBaseURL system preference matches the URL you use to access the staff interface (otherwise the problem is not visible, as the referer is ignored). 3. Log in to the staff interface. 4. Log out. Note the URL is now .../cgi-bin/koha/mainpage.pl?logout.x=1 5. Log in again. 6. Click the language link (e.g. Deutsch) in the bottom bar. => Without the patch you are sent back to mainpage.pl?logout.x=1 and the language does not change. 7. Apply the patch, restart_all, and repeat steps 3-6. => The interface now switches to the chosen language. 8. Confirm the language links still work from other pages, e.g. from a catalogue search results page. 9. Run: prove t/Koha/Util/Navigation.t Signed-off-by: E-P Keskitalo <[email protected]> Signed-off-by: Martin Renvoize <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
