https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43860
--- Comment #11 from Adolfo RodrÃguez Taboada <[email protected]> --- Created attachment 208955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208955&action=edit Bug 43860: (QA follow-up) Move the ISBD punctuation stripping to a template plugin As suggested in comment 10, the punctuation stripping is moved from a TT macro in addbooks.tt to a new template plugin, Koha::Template::Plugin::ISBD, covered by unit tests. The plugin uses the same leading punctuation as C4::Biblio::GetISBDView (spaces and ; : . -), plus , / = and +, and removes the same characters at the end of the value, except full stops, which usually end an abbreviation ("2nd ed.", "316 p."). For dates, trailing full stops are removed too ("c2007."). The previous version used a different set of characters for each field; on the sample data the result is the same. Remove_MARC_punctuation is not used because it only removes one trailing punctuation character, does not handle the leading punctuation (264$b ": Quercus") nor the values joined with " | ", and it is used by the notices, so changing it would affect them. Steps to follow: 1. Apply both patches. 2. Follow the test plan of the first patch: the cataloging search results show the same data as before this follow-up. 3. prove t/Koha_Template_Plugin_ISBD.t xt/author/valid-templates.t Signed-off-by: Adolfo RodrÃguez <[email protected]> Co-Authored-By: Claude Opus 5.5 <[email protected]> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
