https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43860
--- Comment #12 from Adolfo RodrÃguez Taboada <[email protected]> --- Thanks for the review, Lucas! I've added a QA follow-up: 1 and 2. The stripping is now done in Perl, in a new template plugin (Koha::Template::Plugin::ISBD) with unit tests (t/Koha_Template_Plugin_ISBD.t). It uses the same leading punctuation as GetISBDView (spaces and ; : . -), plus , / = and +, and removes the same characters at the end of the values, except full stops, which usually end an abbreviation ("2nd ed.", "316 p."); for dates, the trailing full stop is removed too ("c2007."). Unlike the previous macro, it uses the same set of characters for every field. I compared both versions on all the records of my test database and the output is the same. 3 Remove_MARC_punctuation only removes one trailing punctuation character, so it doesn't handle the leading punctuation (e.g. 264$b ": Quercus"), several characters (" :", ". -"), or the values that Koha joins with " | " for repeated subfields. It is also used by the notices (C4::Letters adds it to biblio and biblioitem fields), so changing its behaviour would affect existing notices. As the follow-up changes how the data is processed, I'm setting the bug back to Needs Signoff. Have a nice day. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
