https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42383
--- Comment #49 from Tomás Cohen Arazi (tcohen) <[email protected]> --- Created attachment 209582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=209582&action=edit Bug 42383: (QA follow-up) Clear the suggested transfer when closing 'Transfer now?' With AutomaticItemReturn disabled, the check-in only suggests a transfer (needs_transfer message) and the 'Transfer now?' modal asks whether to create it. Closing that modal with Escape or by clicking outside it created no transfer, as expected, but the row kept showing the suggested destination and reason in the 'Transfer to' and 'Transfer reason' columns. 'No, don't transfer' cleared them. This patch makes closing the modal without a transfer behave like 'No, don't transfer'. Closing a modal for an existing transfer is unchanged: it is confirmed when AutomaticConfirmTransfer is set, and left pending otherwise. Test plan: 1. Set TransfersBlockCirc and AutomaticItemReturn to "Don't" 2. Check in an item whose home library is not the current library => SUCCESS: The 'Transfer now?' modal is displayed 3. Press Escape => FAIL: No transfer is created, but the row still shows the home library and 'Return to home library' in the transfer columns 4. Apply this patch and rebuild the JS: $ ktd --shell k$ yarn build 5. Repeat steps 2 and 3, then once more clicking outside the modal instead of pressing Escape => SUCCESS: No transfer is created and the transfer columns are empty 6. Repeat step 5 with AutomaticConfirmTransfer set to "Do" => SUCCESS: Same result, no transfer is created 7. Sign off :-D Assisted-by: Opus 5.5 (Anthropic) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
