https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41530
--- Comment #10 from Martin Renvoize (ashimema) <[email protected]> --- Thanks Katrin for the rebase and QA, and Joubu for the review. You were right, the two places you pointed at were still using the old names. I have added a follow-up patch (attachment below): * suggestion/suggestion.tt: the suggestions table read row.item_type and its string, so with the rename the format of a suggestion was no longer shown. It now uses row.item_type_id and _strings.item_type_id. I checked on a suggestion with a format and it is displayed again. * reserve/request.tt: the club hold form posted item_type, which the clubs holds endpoint no longer accepts. It now posts item_type_id. I searched the templates, JS, Vue components and Cypress specs for other users of the three renamed fields and found none (the other item_type occurrences are the item_type object embedded on items, which is a different thing). The follow-up also adds API tests: suggestions expose, filter on and accept item_type_id, and club holds use item_type_id (and no longer accept item_type), and fixes a missing POD that QA flagged in Koha/Item/Transfer/Limit.pm. I have not exercised the club hold form in the browser (the API test covers the endpoint). Setting back to Needs Signoff. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
