https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41530
--- Comment #9 from Martin Renvoize (ashimema) <[email protected]> --- Created attachment 209292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=209292&action=edit Bug 41530: (follow-up) Use item_type_id in the code using the renamed API fields The suggestions and club holds API fields were renamed to item_type_id, but two places still used the old names: * The suggestions table on suggestion/suggestion.pl read row.item_type and its string, so the format of a suggestion was no longer displayed. * The club hold form on reserve/request.pl posted item_type, which the API no longer accepts. Also add API tests for the renamed fields: suggestions expose, filter on and accept item_type_id, and club holds use item_type_id (and no longer accept item_type). To test: 1. Run the API tests: ktd --shell --run 'prove t/db_dependent/api/v1/suggestions.t t/db_dependent/api/v1/clubs_holds.t t/db_dependent/api/v1/transfer_limits.t' 2. Create a suggestion with a format, for example Printed book. Go to Acquisitions > Suggestions and confirm the format is displayed after the title, author and other details of the suggestion. (Before this patch it was missing.) 3. Create a club with enrolled patrons and place a hold for the club on a record from the Place hold page, choosing an item type if prompted. Confirm the holds are placed, with that item type. 4. Sign off Co-Authored-By: Claude Sonnet 5.5 <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
